linux-kernel - Re: [PATCH] dma-mapping:do not initialise statics to 0.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e63cfffa-126c-d6da-207d-43db651d2d92@gmx.de>
Date:   Thu, 21 Jul 2022 10:21:32 +0200
From:   Helge Deller <deller@....de>
To:     Xin Gao <gaoxin@...rlc.com>
Cc:     linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-mapping:do not initialise statics to 0.

On 7/20/22 21:39, Xin Gao wrote:
> do not initialise statics to 0.
>
> Signed-off-by: Xin Gao <gaoxin@...rlc.com>
> ---
>  arch/parisc/kernel/pci-dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/pci-dma.c b/arch/parisc/kernel/pci-dma.c
> index 160996f2198e..ba87f791323b 100644
> --- a/arch/parisc/kernel/pci-dma.c
> +++ b/arch/parisc/kernel/pci-dma.c
> @@ -36,8 +36,8 @@
>  #include <asm/tlbflush.h>	/* for purge_tlb_*() macros */
>
>  static struct proc_dir_entry * proc_gsc_root __read_mostly = NULL;

While at it, you could remove the "= NULL" as well.

Helge

> -static unsigned long pcxl_used_bytes __read_mostly = 0;
> -static unsigned long pcxl_used_pages __read_mostly = 0;
> +static unsigned long pcxl_used_bytes __read_mostly;
> +static unsigned long pcxl_used_pages __read_mostly;
>
>  extern unsigned long pcxl_dma_start; /* Start of pcxl dma mapping area */
>  static DEFINE_SPINLOCK(pcxl_res_lock);