linux-kernel - RE: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Thu, 21 Jul 2022 10:38:50 +0000
From:   Peng Fan <peng.fan@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>,
        "marex@...x.de" <marex@...x.de>,
        "paul.elder@...asonboard.com" <paul.elder@...asonboard.com>,
        "aford173@...il.com" <aford173@...il.com>,
        "Markus.Niebel@...tq-group.com" <Markus.Niebel@...tq-group.com>,
        "alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aisheng Dong <aisheng.dong@....com>
Subject: RE: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl

> Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl
> 
> On 19/07/2022 11:58, Peng Fan wrote:
> >>> +        interconnects:
> >>> +          items:
> >>> +            - description: G1 decoder interconnect
> >>> +            - description: G2 decoder interconnect
> >>> +            - description: VC8000E encoder interconnect
> >>> +
> >>> +        interconnect-names:
> >>> +          items:
> >>> +            - const: g1
> >>> +            - const: g2
> >>> +            - const: vc8000e
> >>
> >> Include interconnects+names in list of all properties and disallow
> >> them for other variants.
> >
> > I not understand well about
> > " Include interconnects+names in list of all properties ", could you
> > please explain a bit more?
> >
> > And there is already an "if" to check whether the compatible contains
> > " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for
> > i.MX8MP, so it is not valid to other variants.
> 
> Defining properties in some if: clause is not really readable and
> maintainable. The properties should be defined in top-level properties:.

Maybe I should also include i.MX8MM interconnect and make it
a separate patch, then i.MX8MP/i.MX8MM just use their own
names just like other properities. In final, as below:

Tow patch:
  1. Add interconnect property for i.MX8MM VPU BLK CTRL
  2. Add i.MX8MP VPU BLK CTRL dt bindings

In top-level:
+ interconnects:
+    maxItems: 3
 
+   interconnect-names:
+      maxItems: 3

For i.MX8MM
+        interconnects:
+          items:
+            - description: G1 decoder interconnect
+            - description: G2 decoder interconnect
+            - description: H1 encoder interconnect
+
+        interconnect-names:
+          items:
+            - const: g1
+            - const: g2
+            - const: h1

For i.MX8MP:
+        interconnects:
+          items:
+            - description: G1 decoder interconnect
+            - description: G2 decoder interconnect
+            - description: VC8000E encoder interconnect
+
+        interconnect-names:
+          items:
+            - const: g1
+            - const: g2
+            - const: vc8000e

How do you think?

Thanks,
Peng.

> 
> 
> Best regards,
> Krzysztof