linux-kernel - Re: [PATCH] HID: nintendo: Add missing array termination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2207211348340.19850@cbobk.fhfr.pm>
Date:   Thu, 21 Jul 2022 13:48:41 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:     Guenter Roeck <linux@...ck-us.net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nergi Rahardi <nergi@...gle.com>,
        "Daniel J . Ogorchock" <djogorchock@...il.com>
Subject: Re: [PATCH] HID: nintendo: Add missing array termination

On Tue, 12 Jul 2022, Dmitry Torokhov wrote:

> On Tue, Jul 12, 2022 at 03:17:05PM -0700, Guenter Roeck wrote:
> > joycon_dpad_inputs_jc[] is unterminated. This may result in odd warnings
> > such as
> > 
> > input: input_set_capability: invalid code 3077588140 for type 1
> > 
> > or in kernel crashes in nintendo_hid_probe(). Terminate the array to fix
> > the problem.
> > 
> > Fixes: 2af16c1f846bd ("HID: nintendo: add nintendo switch controller driver")
> > Cc: Daniel J. Ogorchock <djogorchock@...il.com>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> I'd recommend tagging stable on this one.

I did so and applied, thanks.

-- 
Jiri Kosina
SUSE Labs