lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Jul 2022 14:52:34 +0300 From: Maxim Levitsky <mlevitsk@...hat.com> To: Sean Christopherson <seanjc@...gle.com> Cc: kvm@...r.kernel.org, x86@...nel.org, Kees Cook <keescook@...omium.org>, Dave Hansen <dave.hansen@...ux.intel.com>, linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>, Joerg Roedel <joro@...tes.org>, Ingo Molnar <mingo@...hat.com>, Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Vitaly Kuznetsov <vkuznets@...hat.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com> Subject: Re: [PATCH v2 03/11] KVM: x86: emulator: remove assign_eip_near/far On Wed, 2022-07-20 at 23:51 +0000, Sean Christopherson wrote: > On Tue, Jun 21, 2022, Maxim Levitsky wrote: > > Now the assign_eip_far just updates the emulation mode in addition to > > updating the rip, it doesn't make sense to keep that function. > > > > Move mode update to the callers and remove these functions. > > I disagree, IMO there's a lot of value in differentiating between near and far. > Yeah, the assign_eip_near() wrapper is kinda silly, but have that instead of > a bare assign_eip() documents that e.g. jmp_rel() is a near jump and that it's > not missing an update. > OK, I'll drop this patch then. Best regards, Maxim Levitsky
Powered by blists - more mailing lists