linux-kernel - Re: [PATCH] drm/imx/dcss: get rid of HPD warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jul 2022 15:25:02 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc:     Lucas Stach <l.stach@...gutronix.de>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/imx/dcss: get rid of HPD warning message

Hi Laurentiu,

Thank you for the patch.

On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote:
> When DCSS + MIPI_DSI is used, and the last bridge in the chain supports
> HPD, we can see a "Hot plug detection already enabled" warning stack
> trace dump that's thrown when DCSS is initialized.
> 
> The problem appeared when HPD was enabled by default in the
> bridge_connector initialization, which made the
> drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant.
> So, let's remove that call.
> 
> Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported")
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@....nxp.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 9b84df34a6a12..8cf3352d88582 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -142,8 +142,6 @@ struct dcss_kms_dev *dcss_kms_attach(struct dcss_dev *dcss)
>  
>  	drm_kms_helper_poll_init(drm);
>  
> -	drm_bridge_connector_enable_hpd(kms->connector);
> -
>  	ret = drm_dev_register(drm, 0);
>  	if (ret)
>  		goto cleanup_crtc;

-- 
Regards,

Laurent Pinchart