linux-kernel - Re: [PATCH] dmaengine: idxd: Correct IAX operation code names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YtlJcwuIjw8v9wA0@matsya>
Date:   Thu, 21 Jul 2022 18:11:23 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     Dave Jiang <dave.jiang@...el.com>, Tony Zhu <tony.zhu@...el.com>,
        dmaengine@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Li Zhang <li4.zhang@...el.com>
Subject: Re: [PATCH] dmaengine: idxd: Correct IAX operation code names

On 06-07-22, 17:20, Fenghua Yu wrote:
> Some IAX operation code nomenclatures are misleading or don't match with
> others:
> 
> 1. Operation code 0x4c is Zero Compress 32. IAX_OPCODE_DECOMP_32 is a
>    misleading name. Change it to IAX_OPCODE_ZERO_COMP_32.
> 2. Operation code 0x4d is Zero Compress 16. IAX_OPCODE_DECOMP_16 is a
>    misleading name. Change it to IAX_OPCODE_ZERO_COMP_16.
> 3. IAX_OPCDE_FIND_UNIQUE is corrected to match with other nomenclatures.

Applied, thanks

> 
> Co-developed-by: Li Zhang <li4.zhang@...el.com>
> Signed-off-by: Li Zhang <li4.zhang@...el.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  include/uapi/linux/idxd.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/uapi/linux/idxd.h b/include/uapi/linux/idxd.h
> index bce7c43657d5..095299c75828 100644
> --- a/include/uapi/linux/idxd.h
> +++ b/include/uapi/linux/idxd.h
> @@ -89,14 +89,14 @@ enum iax_opcode {
>  	IAX_OPCODE_CRC64,
>  	IAX_OPCODE_ZERO_DECOMP_32 = 0x48,
>  	IAX_OPCODE_ZERO_DECOMP_16,
> -	IAX_OPCODE_DECOMP_32 = 0x4c,
> -	IAX_OPCODE_DECOMP_16,
> +	IAX_OPCODE_ZERO_COMP_32 = 0x4c,
> +	IAX_OPCODE_ZERO_COMP_16,
>  	IAX_OPCODE_SCAN = 0x50,
>  	IAX_OPCODE_SET_MEMBER,
>  	IAX_OPCODE_EXTRACT,
>  	IAX_OPCODE_SELECT,
>  	IAX_OPCODE_RLE_BURST,
> -	IAX_OPCDE_FIND_UNIQUE,
> +	IAX_OPCODE_FIND_UNIQUE,
>  	IAX_OPCODE_EXPAND,
>  };
>  
> -- 
> 2.32.0

-- 
~Vinod