linux-kernel - Re: [PATCH 2/4] drm/amd/display: Remove duplicated CalculateWriteBackDISPCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14e11a4b-7300-a54d-6794-1eeb7ab8a079@igalia.com>
Date:   Thu, 21 Jul 2022 10:34:56 -0300
From:   André Almeida <andrealmeid@...lia.com>
To:     Maíra Canal <mairacanal@...eup.net>
Cc:     magalilemes00@...il.com, christian.koenig@....com,
        Daniel Vetter <daniel@...ll.ch>, Xinhui.Pan@....com,
        Alex Deucher <alexander.deucher@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Leo Li <sunpeng.li@....com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        tales.aparecida@...il.com, linux-kernel@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, mwen@...lia.com,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        Isabella Basso <isabbasso@...eup.net>, andrealmeid@...eup.net,
        Harry Wentland <harry.wentland@....com>,
        David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH 2/4] drm/amd/display: Remove duplicated
 CalculateWriteBackDISPCLK

Às 15:22 de 20/07/22, Maíra Canal escreveu:
> The functions dml30_CalculateWriteBackDISPCLK and
> dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid
> code duplication, dml31_CalculateWriteBackDISPCLK is removed and
> replaced by dml30_CalculateWriteBackDISPCLK.
> 

The message should be in imperative mood:

"to avoid code duplication, dml31_CalculateWriteBackDISPCLK is removed
and replaced by dml30_CalculateWriteBackDISPCLK." -> "to avoid code
duplication, replace dml31_CalculateWriteBackDISPCLK by
dml30_CalculateWriteBackDISPCLK"

> Signed-off-by: Maíra Canal <mairacanal@...eup.net>
> ---