[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220721142852.2712895-1-pauld@redhat.com>
Date: Thu, 21 Jul 2022 10:28:50 -0400
From: Phil Auld <pauld@...hat.com>
To: linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>,
Peter Zijlstra <peterz@...radead.org>,
Valentin Schneider <vschneid@...hat.com>,
Steven Price <steven.price@....com>
Subject: [PATCH v4 0/2] cpuhp: fix some st->target issues
Fix a couple of cpuhp inconsistencies.
The first prevents target_store() from calling cpu_down() when
target == state which prevents the cpu being incorrectly marked
as dying. The second just makes the boot cpu have a valid cpuhp
target rather than 0 (CPU_OFFLINE) while being in state
CPU_ONLINE.
A further issue which these two patches don't address is that
the cpuX/online file looks at the device->offline state and can
thus get out of sync with the actual cpuhp state if the cpuhp
target is used to change state.
v3: Added code to make sure st->target == target in the nop case.
v4: Use WARN_ON in the case where state == target but st->target does
not.
Phil Auld (2):
cpuhp: make target_store() a nop when target == state
cpuhp: Set cpuhp target for boot cpu
kernel/cpu.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.31.1
Powered by blists - more mailing lists