linux-kernel - Re: [PATCH] kallsyms: make arch_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtlvP1toPTmv4brF@infradead.org>
Date:   Thu, 21 Jul 2022 08:22:39 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ben Dooks <ben-linux@...ff.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kallsyms: make arch_get_kallsym() static

On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> The arch_get_kallsym() function is not used anywhere in the kernel
> now, so it should at-least be static or just be removed as there
> are no users. Making it static fixes the following sparse warning:
> 
> kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?

It fixes the warning, but isn't exactly useful.  Please just remove it,
get_ksymbol_arch and iter->pos_arch_end entirely instead.