linux-kernel - Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 20:19:27 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "hui.liu" <hui.liu@...iatek.com>, linus.walleij@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com
Cc:     johnson.wang@...iatek.com, zhiyong.tao@...iatek.com,
        sean.wang@...iatek.com, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for
 mt8188

On 22/07/2022 03:40, hui.liu wrote:
> Hi, Krzysztof
> 
> That's the comment about reg and reg-names description:
>>> +  reg:
>>> +    description: |
>>> +      Physical address base for gpio base registers. There are 8
>>> GPIO
>>> +      physical address base in mt8188.
>>
>> Redundant description, skip it. You should list the instead and
>> describe
>> each of it.
>>
>>> +    maxItems: 8
>>> +
>>> +  reg-names:
>>> +    description: |
>>> +      Gpio base register names.
>>
>> Redundant description, skip it.
>>
>>> +    maxItems: 8
>>
>> You need to list the items instead.
> 
> I plan to update reg and reg-names as the following:
>   reg:
>     description: |
>       Physical address base for gpio base registers. There are 6
> different GPIO physical address bases in mt8188.
>     minItems: 6
>     maxItems: 6

You should rather have here items with description:
items:
 - description: what is it
 - description: what is it
 ....

> 
>   reg-names:
>     items:
>       - const: iocfg0
>       - const: iocfg_rm
>       - const: iocfg_lt
>       - const: iocfg_lm
>       - const: iocfg_rt
>       - const: eint
> 
> Is it right?
> 
> Thanks.
> 


Best regards,
Krzysztof