linux-kernel - Re: [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 14:33:44 -0400
From:   Mike Snitzer <snitzer@...hat.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Nathan Huckleberry <nhuck@...gle.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Mike Snitzer <snitzer@...nel.org>,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...nel.org>,
        dm-devel@...hat.com, Sami Tolvanen <samitolvanen@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alasdair Kergon <agk@...hat.com>
Subject: Re: [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity

On Fri, Jul 22 2022 at  2:12P -0400,
Bart Van Assche <bvanassche@....org> wrote:

> On 7/22/22 09:41, Christoph Hellwig wrote:
> > We've been tying to kill off task lets for about 15 years.  I don't
> > think adding new users will make you a whole lot of friends..
> 
> +1 for not using tasklets. At least in Android the real-time thread
> scheduling latency is important. Tasklets are not visible to the scheduler
> and hence cause latency spikes for real-time threads. These latency spikes
> can be observed by users, e.g. if the real-time thread is involved in audio
> playback.

OK, then android wouldn't set the _optional_ "try_verify_in_tasklet"

Mike