lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fb10f8bf-d2d8-a2e2-435a-62bb9ce02973@gmail.com>
Date:   Fri, 22 Jul 2022 20:51:05 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Abhijeet Srivastava <abhijeet.srivastava2308@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Rebecca Mckeever <remckee0@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        Vihas Makwana <makvihas@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: r8188eu: Inserted empty line after
 declarations

On 7/22/22 18:16, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
Empty line missing.
> Signed-off-by: Abhijeet Srivastava<abhijeet.srivastava2308@...il.com>
> ---
> v2:
> 	- Fix my name on the patch
> v3:
> 	- Fix commit message
> v4:
> 	- Fix body of explanation

I would like to give you a reviewed by but now the empty line above the 
Signed-off is missing. Please have a look at the canonical patch format.

Regards,
Philipp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ