linux-kernel - Re: [PATCH V6 14/16] PCI: tegra194: Fix link up retry sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+rzy2Y8sD3BhNMxu5QoGHC8gc_oFWiwnpgf_Y1xEnARw@mail.gmail.com>
Date:   Fri, 22 Jul 2022 15:54:55 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Vidya Sagar <vidyas@...dia.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Krzysztof Wilczynski <kw@...ux.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        PCI <linux-pci@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Krishna Thota <kthota@...dia.com>,
        Manikanta Maddireddy <mmaddireddy@...dia.com>,
        sagar.tv@...il.com
Subject: Re: [PATCH V6 14/16] PCI: tegra194: Fix link up retry sequence

On Thu, Jul 21, 2022 at 8:22 AM Vidya Sagar <vidyas@...dia.com> wrote:
>
> Add the missing DLF capability offset while clearing
> DL_FEATURE_EXCHANGE_EN bit during link up retry.
>
> Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
> ---
> V6:
> * New addition in V6 based on Bjorn's review comment

Fixes first, then features. This either be first or not even in this
series. Unless you want to wait on the whole thing to be reviewed.

Though between this and patch 10, I wonder if this driver even worked upstream?

>
>  drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <robh@...nel.org>