[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220722002546.GA2240166-robh@kernel.org>
Date: Thu, 21 Jul 2022 18:25:46 -0600
From: Rob Herring <robh@...nel.org>
To: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc: christophe.jaillet@...adoo.fr, krzysztof.kozlowski+dt@...aro.org,
linux-usb@...r.kernel.org, robh+dt@...nel.org,
amelie.delaunay@...s.st.com, linux-kernel@...r.kernel.org,
alexandre.torgue@...s.st.com, heikki.krogerus@...ux.intel.com,
linux-stm32@...md-mailman.stormreply.com,
devicetree@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: typec: add bindings for stm32g0
controller
On Wed, 13 Jul 2022 14:08:40 +0200, Fabrice Gasnier wrote:
> Add DT schema documentation for the STM32G0 Type-C PD (Power Delivery)
> controller.
> STM32G0 provides an integrated USB Type-C and power delivery interface.
> It can be programmed with a firmware to handle UCSI protocol over I2C
> interface. A GPIO is used as an interrupt line.
> It may be used as a wakeup source, so use optional "wakeup-source" and
> "power-domains" properties to support wakeup.
> The firmware itself may be flashed or later updated (optional). Choice is
> let to the application to allow firmware update. A default firmware could
> be already programmed in production and be customized (to not allow it).
> So the firmware-name is made optional to represent this option.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
> ---
> Changes in v3:
> - Add connector to the required properties as pointed out by Krzysztof.
> Update commit message to explain why the firmware-name is optional.
> Changes in v2:
> - Krzysztof's review comments: update commit message, use ports, use
> unevaluatedProperties: false for usb-connector schema, define maxItems
> for power-domains, adopt generic node names, remove quotes
> ---
> .../bindings/usb/st,typec-stm32g0.yaml | 91 +++++++++++++++++++
> 1 file changed, 91 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/st,typec-stm32g0.yaml
>
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists