linux-kernel - Re: [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 07:54:28 +0200
From:   Peter Geis <pgwipeout@...il.com>
To:     Nicolas Frattaroli <frattaroli.nicolas@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        devicetree <devicetree@...r.kernel.org>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b

On Thu, Jul 21, 2022 at 6:43 AM Nicolas Frattaroli
<frattaroli.nicolas@...il.com> wrote:
>
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
>
> Lower this to sd-uhs-sdr50 to fix this.

I can confirm this is necessary. Thanks!

Tested-by: Peter Geis <pgwipeout@...il.com>

>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@...il.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 02d5f5a8ca03..528bb4e8ac77 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -506,7 +506,7 @@ &sdmmc0 {
>         disable-wp;
>         pinctrl-names = "default";
>         pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> -       sd-uhs-sdr104;
> +       sd-uhs-sdr50;
>         vmmc-supply = <&vcc3v3_sd>;
>         vqmmc-supply = <&vccio_sd>;
>         status = "okay";
> --
> 2.37.1
>