linux-kernel - Re: [PATCH] media: staging: media: zoran: Fixed Block comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 09:32:08 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Abhijeet Srivastava <abhijeet.srivastava2308@...il.com>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        mjpeg-users@...ts.sourceforge.net, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: staging: media: zoran: Fixed Block comments

On Thu, Jul 21, 2022 at 11:07:22PM +0530, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
> 
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@...il.com>
> ---
>  drivers/staging/media/zoran/zoran_driver.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_driver.c b/drivers/staging/media/zoran/zoran_driver.c
> index 4304b7e21709..b408c1d4e0a7 100644
> --- a/drivers/staging/media/zoran/zoran_driver.c
> +++ b/drivers/staging/media/zoran/zoran_driver.c
> @@ -746,9 +746,11 @@ static const struct v4l2_ioctl_ops zoran_ioctl_ops = {
>  	.vidioc_enum_input		    = zoran_enum_input,
>  	.vidioc_g_input			    = zoran_g_input,
>  	.vidioc_s_input			    = zoran_s_input,
> +
>  /*	.vidioc_enum_output		    = zoran_enum_output,
> -	.vidioc_g_output		    = zoran_g_output,
> -	.vidioc_s_output		    = zoran_s_output,*/
> + *	.vidioc_g_output		    = zoran_g_output,
> + *	.vidioc_s_output		    = zoran_s_output,
> + */

Always, just delete dead code.

regards,
dan carpenter