lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Jul 2022 15:16:25 +0800 From: Jianmin Lv <lvjianmin@...ngson.cn> To: Tiezhu Yang <yangtiezhu@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org> Cc: WANG Xuerui <kernel@...0n.name>, Jiaxun Yang <jiaxun.yang@...goat.com>, loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] LoongArch: Remove LOONGARCH_CPUCFG48 and some CSR definitions On 2022/7/22 下午2:58, Tiezhu Yang wrote: > > > On 07/20/2022 04:32 PM, Tiezhu Yang wrote: >> According to the configuration information accessible by the CPUCFG >> instruction [1] and the Overview of Control and Status Registers [2], >> we can not see the descriptions about LOONGARCH_CPUCFG48 (0x30), >> LOONGARCH_CSR_PRID (0xc0), LOONGARCH_CSR_MCSR* (0xc0 ~ 0xff) and >> LOONGARCH_CSR_UCAWIN* (0x100 ~ 0x109), they are not used in the >> current kernel code. >> >> LOONGARCH_CPUCFG48 may be used only in the firmware layer, it should >> not be used in the future for kernel developers, remove the related >> LOONGARCH_CPUCFG48 definitions. >> >> LOONGARCH_CSR_MCSR* is shadow of LOONGARCH_CPUCFG*, no need to access >> LOONGARCH_CSR_MCSR* and LOONGARCH_CSR_PRID through CSR instruction, >> use CPUCFG instruction to access LOONGARCH_CPUCFG* is enough, so also >> remove LOONGARCH_CSR_MCSR* and LOONGARCH_CSR_PRID definitions. >> >> LOONGARCH_CSR_UCAWIN* may be not implemented in hardware, use CSR >> instruction to access them is meaningless, so also remove the related >> LOONGARCH_CSR_UCAWIN* definitions. >> >> The intention of this patch is to keep consistent between the code and >> the manual. >> Agree, they are should be cleaned up for consistency. Acked-by: Jianmin Lv <lvjianmin@...ngson.cn>
Powered by blists - more mailing lists