linux-kernel - Re: [PATCH] irqchip/mmp: fix missing extern init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfmty4ou.wl-maz@kernel.org>
Date:   Fri, 22 Jul 2022 08:41:53 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Ben Dooks <ben-linux@...ff.org>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH] irqchip/mmp: fix missing extern init code

On Thu, 21 Jul 2022 22:51:47 +0100,
Ben Dooks <ben-linux@...ff.org> wrote:
> 
> The functions icu_init_irq and mmp2_init_icu are exported
> from this code, so declare them in the header file to avoid
> the following sparse warnings:
> 
> drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static?
> drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> ---
>  include/linux/irqchip/mmp.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/irqchip/mmp.h b/include/linux/irqchip/mmp.h
> index cb8455c87c8a..aa1813749a4f 100644
> --- a/include/linux/irqchip/mmp.h
> +++ b/include/linux/irqchip/mmp.h
> @@ -4,4 +4,7 @@
>  
>  extern struct irq_chip icu_irq_chip;
>  
> +extern void icu_init_irq(void);
> +extern void mmp2_init_icu(void);
> +
>  #endif	/* __IRQCHIP_MMP_H */
> -- 
> 2.35.1
> 
> 

$ git grep -E "icu_init_irq|mmp2_init_icu"
arch/arm/mach-mmp/mmp2.c:       mmp2_init_icu();
arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
arch/arm/mach-mmp/pxa168.c:     icu_init_irq();
arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
arch/arm/mach-mmp/pxa910.c:     icu_init_irq();
arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)

If you are going to fix this, please fix it sensibly.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.