linux-kernel - Re: [PATCH] irqchip/mmp: fix missing extern init code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pmhxy3ea.wl-maz@kernel.org>
Date:   Fri, 22 Jul 2022 09:09:49 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Ben Dooks <ben@...ff.org>
Cc:     Ben Dooks <ben-linux@...ff.org>, linux-kernel@...r.kernel.org,
        tglx@...utronix.de
Subject: Re: [PATCH] irqchip/mmp: fix missing extern init code

On Fri, 22 Jul 2022 09:03:33 +0100,
Ben Dooks <ben@...ff.org> wrote:
> 
> On Fri, Jul 22, 2022 at 08:41:53AM +0100, Marc Zyngier wrote:
> > On Thu, 21 Jul 2022 22:51:47 +0100,
> > Ben Dooks <ben-linux@...ff.org> wrote:
> > > 
> > > The functions icu_init_irq and mmp2_init_icu are exported
> > > from this code, so declare them in the header file to avoid
> > > the following sparse warnings:
> 
> > $ git grep -E "icu_init_irq|mmp2_init_icu"
> > arch/arm/mach-mmp/mmp2.c:       mmp2_init_icu();
> > arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
> > arch/arm/mach-mmp/pxa168.c:     icu_init_irq();
> > arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
> > arch/arm/mach-mmp/pxa910.c:     icu_init_irq();
> > arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
> > drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
> > drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)
> > 
> > If you are going to fix this, please fix it sensibly.
> 
> Ok, didn't realise these where not being built my the v7_multi defconfig.
> Should this all go into one patch or do the arch/arm bits need to go via
> some arm tree?

One single patch please, which I'll queue directly.

	M.

-- 
Without deviation from the norm, progress is not possible.