linux-kernel - Re: [PATCH] crypto: sahara - don't sleep when in softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 16:17:52 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, javier.martin@...ta-silicon.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH] crypto: sahara - don't sleep when in softirq

On Wed, Jul 13, 2022 at 11:35:50AM +0800, Zhengchao Shao wrote:
> Function of sahara_aes_crypt maybe could be called by function
> of crypto_skcipher_encrypt during the rx softirq, so it is not
> allowed to use mutex lock. This patch is not yet tested.
> 
> Fixes: c0c3c89ae347 ("crypto: sahara - replace tasklets with kthread")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  drivers/crypto/sahara.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
> index 457084b344c1..867107b4ed30 100644
> --- a/drivers/crypto/sahara.c
> +++ b/drivers/crypto/sahara.c
> @@ -26,7 +26,6 @@
>  #include <linux/kernel.h>
>  #include <linux/kthread.h>
>  #include <linux/module.h>
> -#include <linux/mutex.h>

Shouldn't this be replaced with spinlock.h?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt