linux-kernel - Re: [PATCH 2/2] scripts/faddr2line: Add CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 09:41:18 +0100
From:   John Garry <john.garry@...wei.com>
To:     Josh Poimboeuf <jpoimboe@...nel.org>, <x86@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 2/2] scripts/faddr2line: Add CONFIG_DEBUG_INFO check

On 21/07/2022 19:01, Josh Poimboeuf wrote:
> Otherwise without DWARF it spits out gibberish and gives no indication
> of what the problem is.
> 
> Suggested-by: John Garry <john.garry@...wei.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>

Seems to work fine, thanks

Tested-by: John Garry <john.garry@...wei.com>

> ---
>   scripts/faddr2line | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 57099687e5e1..5514c23f45c2 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -61,6 +61,7 @@ die() {
>   READELF="${CROSS_COMPILE:-}readelf"
>   ADDR2LINE="${CROSS_COMPILE:-}addr2line"
>   AWK="awk"
> +GREP="grep"
>   
>   command -v ${AWK} >/dev/null 2>&1 || die "${AWK} isn't installed"
>   command -v ${READELF} >/dev/null 2>&1 || die "${READELF} isn't installed"
> @@ -271,6 +272,8 @@ LIST=0
>   [[ ! -f $objfile ]] && die "can't find objfile $objfile"
>   shift
>   
> +${READELF} --section-headers --wide $objfile | ${GREP} -q '\.debug_info' || die "CONFIG_DEBUG_INFO not enabled"
> +
>   DIR_PREFIX=supercalifragilisticexpialidocious
>   find_dir_prefix $objfile
>