[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <0503175d-944d-4ffa-ba39-ff99797e78a1@www.fastmail.com>
Date: Fri, 22 Jul 2022 11:44:31 +0930
From: "Andrew Jeffery" <andrew@...id.au>
To: "Miaoqian Lin" <linmq006@...il.com>,
"Joel Stanley" <joel@....id.au>,
"Chia-Wei, Wang" <chiawei_wang@...eedtech.com>,
"Patrick Venture" <venture@...gle.com>,
"Robert Lippert" <roblip@...il.com>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq
On Fri, 3 Jun 2022, at 22:09, Miaoqian Lin wrote:
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
> int irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
Reviewed-by: Andrew Jeffery <andrew@...id.au>
Powered by blists - more mailing lists