linux-kernel - Re: [PATCH linux-next] soc: mediatek:fix the compile warning which about svs_resume() and svs_suspend() When the static function are not be used,there gonna be a WARNNING for it. Ignore these will make the compile to sucess and should not effect any other thing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 12:56:16 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     cgel.zte@...il.com, linux-kernel@...r.kernel.org
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        ye xingchen <ye.xingchen@....com.cn>
Subject: Re: [PATCH linux-next] soc: mediatek:fix the compile warning which
 about svs_resume() and svs_suspend() When the static function are not be
 used,there gonna be a WARNNING for it. Ignore these will make the compile to
 sucess and should not effect any other thing.

Hi Ye Xingchen,

On 22/07/2022 07:46, cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Reported-by: Zeal Robot<ye.xingchen@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>

Thanks for your patch. Unfortunately that got already fixed in my tree with this 
patch:
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.19-next/soc&id=c749d676a33d99ee4c40d69ac2bf280270d890ad

Regards,
Matthias

> ---
>   drivers/soc/mediatek/mtk-svs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index dee8664a12fd..f411fcda8c6d 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
>   	return 0;
>   }
>   
> -static int svs_suspend(struct device *dev)
> +__maybe_unused static int svs_suspend(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	struct svs_bank *svsb;
> @@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
>   	return 0;
>   }
>   
> -static int svs_resume(struct device *dev)
> +__maybe_unused static int svs_resume(struct device *dev)
>   {
>   	struct svs_platform *svsp = dev_get_drvdata(dev);
>   	int ret;