linux-kernel - RE: [PATCH net-next v3 27/47] net: fman: Inline several functions into initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB5807164E1AE9BF21F6434D85F2909@VI1PR04MB5807.eurprd04.prod.outlook.com>
Date:   Fri, 22 Jul 2022 12:30:00 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Sean Anderson <sean.anderson@...o.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Madalin Bucur <madalin.bucur@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Russell King <linux@...linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v3 27/47] net: fman: Inline several functions
 into initialization

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...o.com>
> Sent: Thursday, July 21, 2022 18:34
> To: Camelia Alexandra Groza <camelia.groza@....com>; David S . Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Madalin Bucur
> <madalin.bucur@....com>; netdev@...r.kernel.org
> Cc: Paolo Abeni <pabeni@...hat.com>; Eric Dumazet
> <edumazet@...gle.com>; linux-arm-kernel@...ts.infradead.org; Russell
> King <linux@...linux.org.uk>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into initialization
> 
> 
> 
> On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
> >> -----Original Message-----
> >> From: Sean Anderson <sean.anderson@...o.com>
> >> Sent: Saturday, July 16, 2022 1:00
> >> To: David S . Miller <davem@...emloft.net>; Jakub Kicinski
> >> <kuba@...nel.org>; Madalin Bucur <madalin.bucur@....com>;
> >> netdev@...r.kernel.org
> >> Cc: Paolo Abeni <pabeni@...hat.com>; Eric Dumazet
> >> <edumazet@...gle.com>; linux-arm-kernel@...ts.infradead.org; Russell
> >> King <linux@...linux.org.uk>; linux-kernel@...r.kernel.org; Sean
> Anderson
> >> <sean.anderson@...o.com>
> >> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into
> >> initialization
> >>
> >> There are several small functions which weer only necessary because the
> >
> > *were* typo.
> 
> Hm, I thought commit messages were supposed to be written as if the patch
> hadn't
> yet been applied (e.g. the current state as the patch is reviewed).

That's my understanding as well. I was pointing out this bit: "which weer only necessary ".
I assume you wanted to type "were" here.

> >> initialization functions didn't have access to the mac private data. Now
> >> that they do, just do things directly.
> >>
> >> Signed-off-by: Sean Anderson <sean.anderson@...o.com>
> >
> > Acked-by: Camelia Groza <camelia.groza@....com>
> >