linux-kernel - Re: [PATCH] HID: alps: Declare U1_UNICORN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jul 2022 15:02:52 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Artem Borisov <dedsa2002@...il.com>
cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: alps: Declare U1_UNICORN_LEGACY support

On Tue, 19 Jul 2022, Artem Borisov wrote:

> U1_UNICORN_LEGACY id was added to the driver, but was not declared
> in the device id table, making it impossible to use.
> 
> Fixes: 640e403 ("HID: alps: Add AUI1657 device ID")
> Signed-off-by: Artem Borisov <dedsa2002@...il.com>
> ---
>  drivers/hid/hid-alps.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
> index 2b986d0dbde4..db146d0f7937 100644
> --- a/drivers/hid/hid-alps.c
> +++ b/drivers/hid/hid-alps.c
> @@ -830,6 +830,8 @@ static const struct hid_device_id alps_id[] = {
>  		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
>  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
>  		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1) },
> +	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
> +		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY) },
>  	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
>  		USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_T4_BTNLESS) },
>  	{ }

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs