linux-kernel - Re: [PATCH] HID: nintendo: Fix unused-const-variable compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2207221504020.19850@cbobk.fhfr.pm>
Date:   Fri, 22 Jul 2022 15:04:17 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Aashish Sharma <shraash@...gle.com>
cc:     "Daniel J . Ogorchock " <djogorchock@...il.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: nintendo: Fix unused-const-variable compiler
 warning

On Wed, 20 Jul 2022, Aashish Sharma wrote:

> The following compiler warning is produced when CONFIG_NINTENDO_FF
> is not set:
> 
> >> drivers/hid/hid-nintendo.c:405:29: warning: 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
>    defined but not used [-Wunused-const-variable=]
> 
> To fix this, move the variable 'JC_RUMBLE_ZERO_AMP_PKT_CNT' under the
> CONFIG_NINTENDO_FF's conditional compilation block.
> 
> Signed-off-by: Aashish Sharma <shraash@...gle.com>

Applied to for-5.20/ninitendo. Thanks,

-- 
Jiri Kosina
SUSE Labs