linux-kernel - Re: [PATCH] keys/keyctl: Use kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YtwAHGISvlgXgXZM@kroah.com>
Date:   Sat, 23 Jul 2022 16:05:16 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Siddh Raman Pant <code@...dh.me>
Cc:     David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-modules <linux-security-module@...r.kernel.org>,
        keyrings <keyrings@...r.kernel.org>,
        linux-kernel-mentees 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree

On Sat, Jul 23, 2022 at 07:20:35PM +0530, Siddh Raman Pant via Linux-kernel-mentees wrote:
> In keyctl_watch_key, use kfree_rcu() for freeing watch and wlist
> as they support RCU and have an rcu_head in the struct definition.

That does not explain why this change is needed.  What problem does this
solve?  Why use RCU if you don't have to?  What functionality did you
just change in this commit and why?

And how was this tested?

thanks,

greg k-h