linux-kernel - Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <875d6856-dea4-e1ff-60b3-706cf00f8bb9@linaro.org>
Date:   Sat, 23 Jul 2022 19:32:49 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Chengci.Xu" <chengci.xu@...iatek.com>,
        Yong Wu <yong.wu@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        srv_heupstream@...iatek.com
Subject: Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM
 master

On 23/07/2022 05:19, Chengci.Xu wrote:

Thank you for your patch. There is something to discuss/improve.

>  #endif
> diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
> index 11f7d6b59642..76093b856335 100644
> --- a/include/soc/mediatek/smi.h
> +++ b/include/soc/mediatek/smi.h
> @@ -8,6 +8,15 @@
>  
>  #include <linux/bitops.h>
>  #include <linux/device.h>
> +#include <linux/arm-smccc.h>
> +#include <linux/soc/mediatek/mtk_sip_svc.h>

The headers do not look like used here. Include only relevant headers.

> +
> +/* IOMMU & SMI ATF CMD */
> +
> +enum IOMMU_ATF_CMD {
> +	IOMMU_ATF_CMD_CONFIG_SMI_LARB,		/* For mm master to en/disable iommu */
> +	IOMMU_ATF_CMD_COUNT,
> +};
>  
>  #if IS_ENABLED(CONFIG_MTK_SMI)
>  


Best regards,
Krzysztof