[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6a4c74fe-5558-5455-1f79-0289e10294b2@linaro.org>
Date: Sat, 23 Jul 2022 20:10:04 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sam Ravnborg <sam@...nborg.org>
Cc: Thierry Reding <thierry.reding@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Mark Brown <broonie@...nel.org>,
Tomi Valkeinen <tomi.valkeinen@...com>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Maxime Ripard <mripard@...nel.org>,
Marek Belisko <marek@...delico.com>,
"H. Nikolaus Schaller" <hns@...delico.com>,
Pratyush Yadav <p.yadav@...com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
Jonathan Cameron <jic23@...nel.org>,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from
common properties
On 22/07/2022 21:45, Sam Ravnborg wrote:
> Hi Krzysztof
>
> On Fri, Jul 22, 2022 at 09:15:39PM +0200, Krzysztof Kozlowski wrote:
>> The spi-cpha and spi-cpol properties are device specific and should be
>> accepted only if device really needs them. Drop them from common
>> spi-peripheral-props.yaml schema, mention in few panel drivers which use
>> themi
>
> "and include instead in the SPI controller bindings."
>
> I cannot see you do this in the touched bindings.
Yep, because you always have two schemas being in play. One is SPI
controller and other is the device (SPI slave).
> So I cannot see how for example samsung,ld9040.yaml picks up
> spi-controller.yaml and thus it no longer knows the spi-cpha and spi-cpol
> properties.
ld9040 is not spi-controller, but a SPI slave device, AFAIU. It will be
therefore a child of some SPI controller, thus the SPI controller
schema, which includes spi-controller.yaml, will validate the type of
spi-cpha/cpol properties.
Best regards,
Krzysztof
Powered by blists - more mailing lists