linux-kernel - Re: [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Jul 2022 23:43:01 +0300
From:   Matti Lehtimäki <matti.lehtimaki@...il.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab
 4 10.1 (SM-T530)

On 24.7.2022 21.55, Dmitry Baryshkov wrote:
> On Sun, 24 Jul 2022 at 20:25, Matti Lehtimäki <matti.lehtimaki@...il.com> wrote:
>> +/delete-node/ &smem_region;
> 
> Please move this to the /reserved-memory node. having it there would
> help understanding that we are just changing the address.

I can move this to /reserved-memory node in next version. Other option
would be to have a comment here, it seems both ways are used.

>> +       i2c-muic {
>> +               compatible = "i2c-gpio";
> 
> Is there any reason for using i2c-gpio rather than blsp_i2c4?
> According to the pinctrl-msm8226, gpio14/15 can be mapped to the blsp.

The reason to use i2c-gpio for this was using the other devices with
similar node as an example. I tested and having the muic node in
blsp_i2c4 worked the same.

-Matti