linux-kernel - [arnd-playground:orion-pci-cleanup 4/5] arch/arm/mach-orion5x/pci.c:537:10: warning: variable 'ret' is uninitialized when used here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 25 Jul 2022 06:27:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [arnd-playground:orion-pci-cleanup 4/5]
 arch/arm/mach-orion5x/pci.c:537:10: warning: variable 'ret' is uninitialized
 when used here

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git orion-pci-cleanup
head:   f154fdd063e0f8e231dbe3c06b03fbb1ec0ffb8c
commit: a6ab62c0b851be42f112f08681f361157dd7466b [4/5] ARM: orion5x: split up PCI/PCIe driver in two
config: arm-mvebu_v5_defconfig (https://download.01.org/0day-ci/archive/20220725/202207250651.oVxG50vj-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0c1b32717bcffcf8edf95294e98933bd4c1e76ed)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commit/?id=a6ab62c0b851be42f112f08681f361157dd7466b
        git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
        git fetch --no-tags arnd-playground orion-pci-cleanup
        git checkout a6ab62c0b851be42f112f08681f361157dd7466b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/arm/mach-orion5x/pci.c:537:10: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
                   return ret;
                          ^~~
   arch/arm/mach-orion5x/pci.c:495:9: note: initialize the variable 'ret' to silence this warning
           int ret;
                  ^
                   = 0
   1 warning generated.


vim +/ret +537 arch/arm/mach-orion5x/pci.c

   489	
   490	int __init orion5x_pci_init(int (*map_irq)(const struct pci_dev *dev, u8 slot, u8 pin))
   491	{
   492		struct pci_host_bridge *bridge;
   493		struct orion5x_pci_sys_data *sys;
   494		int nr = 1;
   495		int ret;
   496	
   497		pci_add_flags(PCI_REASSIGN_ALL_BUS);
   498	
   499		bridge = pci_alloc_host_bridge(sizeof(struct orion5x_pci_sys_data));
   500		if (!bridge) {
   501			pr_err("PCI: unable to allocate bridge!");
   502			return -ENOMEM;
   503		}
   504	
   505		sys = pci_host_bridge_priv(bridge);
   506	
   507		bridge->ops = &pci_ops;
   508		bridge->map_irq = map_irq;
   509		bridge->swizzle_irq = pci_common_swizzle;
   510	
   511		orion5x_pci_set_bus_nr(bridge->busnr);
   512	
   513		/*
   514		 * Point PCI unit MBUS decode windows to DRAM space.
   515		 */
   516		orion5x_setup_pci_wins();
   517	
   518		/*
   519		 * Master + Slave enable
   520		 */
   521		orion5x_pci_master_slave_enable();
   522	
   523		/*
   524		 * Force ordering
   525		 */
   526		orion5x_setbits(PCI_CMD, PCI_CMD_HOST_REORDER);
   527	
   528		/*
   529		 * IORESOURCE_MEM
   530		 */
   531		sys->mem_res.name = "PCI Memory Space";
   532		sys->mem_res.flags = IORESOURCE_MEM;
   533		sys->mem_res.start = ORION5X_PCI_MEM_PHYS_BASE;
   534		sys->mem_res.end = sys->mem_res.start + ORION5X_PCI_MEM_SIZE - 1;
   535		if (request_resource(&iomem_resource, &sys->mem_res)) {
   536			pr_err("PCI: unable to allocate I/O port region (%d)\n", ret);
 > 537			return ret;
   538		}
   539		pci_add_resource(&bridge->windows, &sys->mem_res);
   540	
   541		/*
   542		 * IORESOURCE_IO
   543		 */
   544		sys->io_res.start = (nr * SZ_64K) ?  : pcibios_min_io;
   545		sys->io_res.end = (nr + 1) * SZ_64K - 1;
   546		sys->io_res.flags = IORESOURCE_IO;
   547		sys->io_res.name = "PCI I/O";
   548		ret = request_resource(&ioport_resource, &sys->io_res);
   549		if (ret) {
   550			pr_err("PCI: unable to allocate I/O port region (%d)\n", ret);
   551			return ret;
   552		}
   553		pci_remap_iospace(&sys->io_res, ORION5X_PCI_IO_PHYS_BASE);
   554		pci_add_resource(&bridge->windows, &sys->io_res);
   555	
   556		ret = pci_host_probe(bridge);
   557	
   558		if (WARN(ret < 0, "PCI: unable to scan bus!"))
   559			pci_free_host_bridge(bridge);
   560	
   561		return ret;
   562	}
   563	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp