linux-kernel - Re: [PATCH] tracing/kprobe: Add tracefs to show private kprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220724191931.60c671e2@rorschach.local.home>
Date:   Sun, 24 Jul 2022 19:19:31 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jianlin Lv <iecedge@...il.com>
Cc:     mingo@...hat.com, jianlv@...y.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/kprobe: Add tracefs to show private kprobe

On Sun, 24 Jul 2022 09:10:50 +0000
Jianlin Lv <iecedge@...il.com> wrote:

> List private kprobe event to new created local_event_list;
> Add tracefs file kprobe_local_profile to show events which
> in local_event_list.

This states what you are doing, but not why you are doing it.

The subject of a commit should be the what, and the body should explain
the why.

And the subject is confusing because you are not "adding tracefs", it
should state:

   tracing/kprobes: Add method to display private kprobes in tracefs

Or something like that.

-- Steve