Message-ID: <afbf1692-9942-b337-4195-a38c0cba793e@linux.alibaba.com>
Date:   Sun, 24 Jul 2022 10:38:06 +0800
From:   tianxianting <xianting.tian@...ux.alibaba.com>
To:     Dave Young <dyoung@...hat.com>,
        "Discussion list for crash utility usage, maintenance and development" 
        <crash-utility@...hat.com>
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, anup@...infault.org, heiko@...ech.de,
        guoren@...nel.org, mick@....forth.gr,
        alexandre.ghiti@...onical.com, huanyi.xj@...baba-inc.com,
        hschauhan@...ltrace.org, linux-kernel@...r.kernel.org,
        heinrich.schuchardt@...onical.com, linux-riscv@...ts.infradead.org,
        kexec@...ts.infradead.org
Subject: Re: [Crash-utility] [PATCH 0/5] Fixups to work with crash tool


在 2022/7/22 下午4:13, Dave Young 写道:
> Hi,
>
> On Sun, 17 Jul 2022 at 18:13, Xianting Tian
> <xianting.tian@...ux.alibaba.com> wrote:
>> I ever sent the patch 1,2 in the link:
>> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-2-xianting.tian@linux.alibaba.com/
>> https://patchwork.kernel.org/project/linux-riscv/patch/20220708073150.352830-3-xianting.tian@linux.alibaba.com/
>> And patch 3,4 in the link:
>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-2-xianting.tian@linux.alibaba.com/
>> https://patchwork.kernel.org/project/linux-riscv/patch/20220714113300.367854-3-xianting.tian@linux.alibaba.com/
>>
>> This patch series just put these patches together, and with a new patch 5.
>> these five patches are the fixups for kexec, vmcore and improvements
>> for vmcoreinfo and memory layout dump.
>>
>> The main changes in the five patchs as below,
>> Patch 1: Add a fast call path of crash_kexec() as other Arch(x86, arm64) do.
>> Patch 2: use __smp_processor_id() instead of smp_processor_id() to cleanup
>>           the console prints.
>> Patch 3: Add VM layout, va bits, ram base to vmcoreinfo, which can simplify
>>           the development of crash tool as ARM64 already did
>>           (arch/arm64/kernel/crash_core.c).
>> Patch 4: Add modules to virtual kernel memory layout dump.
>> Patch 5: Fixup to get correct kernel mode PC for vmcore
>>
>> With these 5 patches(patch 3 is must), crash tool can work well to analyze
>> a vmcore. The patches for crash tool for RISCV64 is in the link:
>> https://lore.kernel.org/linux-riscv/20220717042929.370022-1-xianting.tian@linux.alibaba.com/
>>
>> Xianting Tian (5):
>>    RISC-V: Fixup fast call of crash_kexec()
>>    RISC-V: use __smp_processor_id() instead of smp_processor_id()
>>    RISC-V: Add arch_crash_save_vmcoreinfo support
> Vmcoreinfo changes need to be documented in
> Documentation/admin-guide/kdump/vmcoreinfo.rst
>
> Otherwise, I suggest to always cc kexec mail list (added in cc) for
> kexec | kdump patches.
>
> thanks, I will fix it in v3.
>>    riscv: Add modules to virtual kernel memory layout dump
>>    RISC-V: Fixup getting correct current pc
>>
>>   arch/riscv/kernel/Makefile          |  1 +
>>   arch/riscv/kernel/crash_core.c      | 29 +++++++++++++++++++++++++++++
>>   arch/riscv/kernel/crash_save_regs.S |  2 +-
>>   arch/riscv/kernel/machine_kexec.c   |  2 +-
>>   arch/riscv/kernel/traps.c           |  4 ++++
>>   arch/riscv/mm/init.c                |  4 ++++
>>   6 files changed, 40 insertions(+), 2 deletions(-)
>>   create mode 100644 arch/riscv/kernel/crash_core.c
>>
>> --
>> 2.17.1
>>
>> --
>> Crash-utility mailing list
>> Crash-utility@...hat.com
>> https://listman.redhat.com/mailman/listinfo/crash-utility
>> Contribution Guidelines: https://github.com/crash-utility/crash/wiki
>>
> Thanks
> Dave

Powered by blists - more mailing lists