linux-kernel - Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qu9em7c.wl-tiwai@suse.de>
Date:   Mon, 25 Jul 2022 08:32:55 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Ren Zhijie <renzhijie2@...wei.com>
Cc:     <james.schulman@...rus.com>, <david.rhodes@...rus.com>,
        <tanureal@...nsource.cirrus.com>, <rf@...nsource.cirrus.com>,
        <perex@...ex.cz>, <tiwai@...e.com>,
        <sbinding@...nsource.cirrus.com>, <vitalyr@...nsource.cirrus.com>,
        patches@...nsource.cirrus.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function

On Mon, 25 Jul 2022 04:36:11 +0200,
Ren Zhijie wrote:
> 
> If CONFIG_PM_SLEEP is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
> 
> sound/pci/hda/cs35l41_hda.c:583:12: error: ‘cs35l41_runtime_resume’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~
> sound/pci/hda/cs35l41_hda.c:565:12: error: ‘cs35l41_runtime_suspend’ defined but not used [-Werror=unused-function]
>  static int cs35l41_runtime_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1
> 
> commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.
> 
> Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>

Thanks, applied.


Takashi