linux-kernel - Re: [PATCH v10 08/12] iommu/sva: Refactoring iommu_sva_bind/unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt5IqyZw/Sa6Ck5t@myrica>
Date:   Mon, 25 Jul 2022 08:39:23 +0100
From:   Jean-Philippe Brucker <jean-philippe@...aro.org>
To:     Baolu Lu <baolu.lu@...ux.intel.com>
Cc:     Jason Gunthorpe <jgg@...dia.com>, Joerg Roedel <joro@...tes.org>,
        Christoph Hellwig <hch@...radead.org>,
        Kevin Tian <kevin.tian@...el.com>,
        Ashok Raj <ashok.raj@...el.com>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Vinod Koul <vkoul@...nel.org>,
        Eric Auger <eric.auger@...hat.com>,
        Liu Yi L <yi.l.liu@...el.com>,
        Jacob jun Pan <jacob.jun.pan@...el.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        Zhu Tony <tony.zhu@...el.com>, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 08/12] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()

On Sun, Jul 24, 2022 at 09:48:15PM +0800, Baolu Lu wrote:
> /*
>  * iommu_detach_device_pasid() - Detach the domain from pasid of device
>  * @domain: the iommu domain.
>  * @dev: the attached device.
>  * @pasid: the pasid of the device.
>  *
>  * The @domain must have been attached to @pasid of the @dev with
>  * iommu_detach_device_pasid().
>  */
> void iommu_detach_device_pasid(struct iommu_domain *domain, struct device
> *dev,
> 			       ioasid_t pasid)
> {
> 	struct iommu_group *group = iommu_group_get(dev);
> 	struct group_pasid *param;
> 
> 	mutex_lock(&group->mutex);
> 	domain->ops->set_dev_pasid(group->blocking_domain, dev, pasid);

Please also pass the old domain to this detach() function, so that the
IOMMU driver doesn't have to keep track of them internally.

In addition to clearing contexts, detach() also needs to invalidate TLBs,
and for that the SMMU driver needs to know the old ASID (!= PASID) that
was used by the context descriptor.

Thanks,
Jean