lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Jul 2022 09:53:21 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: Vikas Gupta <vikas.gupta@...adcom.com>, jiri@...dia.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net, dsahern@...nel.org, stephen@...workplumber.org, edumazet@...gle.com, pabeni@...hat.com, ast@...nel.org, leon@...nel.org, linux-doc@...r.kernel.org, corbet@....net, michael.chan@...adcom.com, andrew.gospodarek@...adcom.com Subject: Re: [PATCH net-next v6 1/2] devlink: introduce framework for selftests Sat, Jul 23, 2022 at 06:16:00PM CEST, kuba@...nel.org wrote: >On Sat, 23 Jul 2022 09:52:05 +0530 Vikas Gupta wrote: >> +enum devlink_attr_selftest_test_id { >> + DEVLINK_ATTR_SELFTEST_TEST_ID_UNSPEC, >> + DEVLINK_ATTR_SELFTEST_TEST_ID_FLASH, /* flag */ >> + >> + __DEVLINK_ATTR_SELFTEST_TEST_ID_MAX, >> + DEVLINK_ATTR_SELFTEST_TEST_ID_MAX = __DEVLINK_ATTR_SELFTEST_TEST_ID_MAX - 1 >> +}; >> + >> +enum devlink_selftest_test_status { >> + DEVLINK_SELFTEST_TEST_STATUS_SKIP, >> + DEVLINK_SELFTEST_TEST_STATUS_PASS, >> + DEVLINK_SELFTEST_TEST_STATUS_FAIL >> +}; >> + >> +enum devlink_attr_selftest_result { >> + DEVLINK_ATTR_SELFTEST_RESULT_UNSPEC, >> + DEVLINK_ATTR_SELFTEST_RESULT, /* nested */ >> + DEVLINK_ATTR_SELFTEST_RESULT_TEST_ID, /* u32, >> + * enum devlink_attr_selftest_test_id >> + */ >> + DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS, /* u8, >> + * enum devlink_selftest_test_status >> + */ >> + >> + __DEVLINK_ATTR_SELFTEST_RESULT_MAX, >> + DEVLINK_ATTR_SELFTEST_RESULT_MAX = __DEVLINK_ATTR_SELFTEST_RESULT_MAX - 1 > >Any thoughts on running: > > sed -i '/_SELFTEST/ {s/_TEST_/_/g}' $patch Sure, why not. But please make sure you keep all other related things (variables, cmdline opts) consistent. Thanks! > >on this patch? For example DEVLINK_ATTR_SELFTEST_RESULT_TEST_STATUS >is 40 characters long, ain't nobody typing that, and _TEST is repeated.. > >Otherwise LGTM!
Powered by blists - more mailing lists