linux-kernel - Re: linux-next: build failure after merge of the hid tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2207251142040.19850@cbobk.fhfr.pm>
Date:   Mon, 25 Jul 2022 11:42:26 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Aashish Sharma <shraash@...gle.com>,
        "Daniel J. Ogorchock" <djogorchock@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the hid tree

On Mon, 25 Jul 2022, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/hid/hid-nintendo.c:1514:29: error: redefinition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT'
>  1514 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/hid/hid-nintendo.c:295:29: note: previous definition of 'JC_RUMBLE_ZERO_AMP_PKT_CNT' with type 'short unsigned int'
>   295 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   669abca7b767 ("HID: nintendo: Fix unused-const-variable compiler warning")
> 
> interacting with commit
> 
>   92cdfba40155 ("HID: nintendo: fix unused const warning")
> 
> I have used the hid tree from next-20220722 for today.

My fault, I forgot that this was actually already fixed before by Daniel.

Dropped for now from for-next. Thanks,

-- 
Jiri Kosina
SUSE Labs