linux-kernel - Re: [PATCH 1/2] regmap: Support accelerated noinc operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yt6CdDg5I70fMdOK@sirena.org.uk>
Date:   Mon, 25 Jul 2022 12:45:56 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regmap: Support accelerated noinc operations

On Mon, Jul 25, 2022 at 10:58:21AM +0200, Linus Walleij wrote:

> +	/* Use the accelerated operation if we can */
> +	if (map->bus->reg_noinc_write) {
> +		size_t val_bytes = map->format.val_bytes;

A lot of duplicated buffer formatting in here...  that should probably
be factored out rather than copied, otherwise the noinc stuff is going
to drift out of sync.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)