linux-kernel - Re: [PATCH] ASoC: amd: acp: Modify dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Yt6GW/29wJ9081rh@sirena.org.uk>
Date:   Mon, 25 Jul 2022 13:02:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "Prasad, Prasad" <venkataprasad.potturu@....com>
Cc:     "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Reddy, V sujith kumar" <Vsujithkumar.Reddy@....com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@....com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@....com>,
        "Saba Kareem, Syed" <Syed.SabaKareem@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Ajit Kumar Pandey <AjitKumar.Pandey@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic

On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:

> This looks like it's just an indentation/formatting change which isn't
> 
> what the changelog said?

> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
> 
> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
> I2S_HS_INSTANCE is already 0x03.

Please write a better changelog which makes this clear.

Please fix your e-mail client to clearly distinguish between quoted and
non-quoted text, it's very hard to find your new text in your mail.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)