linux-kernel - Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9e12738-8de4-bce9-a181-b3d231b18e42@roeck-us.net>
Date:   Mon, 25 Jul 2022 07:07:17 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Alexey Klimov <klimov.linux@...il.com>
Cc:     linux-watchdog@...r.kernel.org, wim@...ux-watchdog.org,
        oneukum@...e.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, atishp@...osinc.com,
        atishp@...shpatra.org, yury.norov@...il.com, aklimov@...hat.com,
        atomlin@...hat.com
Subject: Re: [PATCH v5] watchdog: add driver for StreamLabs USB watchdog
 device

On 7/25/22 01:51, Greg KH wrote:
> On Mon, Jul 25, 2022 at 04:06:05AM +0100, Alexey Klimov wrote:
>> +static bool nowayout = WATCHDOG_NOWAYOUT;
>> +module_param(nowayout, bool, 0);
>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
>> +			__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>> +
> 
> Meta-comment about watchdog drivers, this is per-driver, not per-device,
> which does not make sense for when these devices are on removable busses
> where you can have multiple ones.
> 

It is really intended to be a system configuration parameter
(CONFIG_WATCHDOG_NOWAYOUT) which can be overridden. Also, I think it still
makes sense to have it, even for removable devices. The ability to bypass
the flag by pulling the device would defeat its purpose.

Guenter

> I don't suggest changing this (as it follows the current style of other
> watchdog drivers), but perhaps a sysfs attribute for watchdog devices
> can do the same thing in the future so you can do this on a per-device
> basis.
> 
> Anyway, driver looks good to me, nice work!
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>