linux-kernel - Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt6zuvatUa0gtYjn@google.com>
Date:   Mon, 25 Jul 2022 16:16:10 +0100
From:   Vincent Donnefort <vdonnefort@...gle.com>
To:     Valentin Schneider <vschneid@...hat.com>
Cc:     peterz@...radead.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, regressions@...mhuis.info,
        kernel-team@...roid.com, Derek Dolney <z23@...teo.net>
Subject: Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING
 sections

On Mon, Jul 25, 2022 at 04:07:47PM +0100, Valentin Schneider wrote:
> On 25/07/22 10:59, Vincent Donnefort wrote:
> > The DYING/STARTING callbacks are not expected to fail. However, as reported
> > by Derek, drivers such as tboot are still free to return errors within
> > those sections, which halts the hot(un)plug and leaves the CPU in an
> > unrecoverable state.
> >
> > No rollback being possible there, let's only log the failures and proceed
> > with the following steps. This restores the hotplug behaviour prior to
> > commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
> > Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> > Reported-by: Derek Dolney <z23@...teo.net>
> > Signed-off-by: Vincent Donnefort <vdonnefort@...gle.com>
> > Tested-by: Derek Dolney <z23@...teo.net>
> >
> 
> The changelog has some undesired stowaways below, but regardless:
> Reviewed-by: Valentin Schneider <vschneid@...hat.com>

Arg indeed, my bad. But thanks for the tag!

> 
> > v4 -> v5:
> >    - Remove WARN, only log broken states with pr_warn.
> > v3 -> v4:
> >    - Sorry ... wrong commit description style ...
> > v2 -> v3:
> >    - Tested-by tag.
> >    - Refine commit description.
> >    - Bugzilla link.
> > v1 -> v2:
> >    - Commit message rewording.
> >    - More details in the warnings.
> >    - Some variable renaming
> >
>