linux-kernel - Re: [PATCH] ASoC: max98373: Removing 0x203E from the volatile reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jul 2022 10:03:23 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Ryan Lee <ryan.lee.analog@...il.com>, lgirdwood@...il.com,
        broonie@...nel.org, perex@...ex.cz, tiwai@...e.com, steve@....org,
        ryans.lee@...log.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: max98373: Removing 0x203E from the volatile reg



On 7/22/22 20:52, Ryan Lee wrote:
> The 0x203E speaker gain register should be non-volatile.
> This register value was not able to be synced because it was marked as
> volatile.
> 
> Signed-off-by: Ryan Lee <ryans.lee@...log.com>
> ---
>  sound/soc/codecs/max98373-i2c.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/max98373-i2c.c b/sound/soc/codecs/max98373-i2c.c
> index 4fe065ece17c..3e04c7f0cce4 100644
> --- a/sound/soc/codecs/max98373-i2c.c
> +++ b/sound/soc/codecs/max98373-i2c.c
> @@ -442,7 +442,6 @@ static bool max98373_volatile_reg(struct device *dev, unsigned int reg)
>  {
>  	switch (reg) {
>  	case MAX98373_R2000_SW_RESET ... MAX98373_R2009_INT_FLAG3:
> -	case MAX98373_R203E_AMP_PATH_GAIN:

That register isn't declared as volatile for the SoundWire case so that
sounds like a good fix

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

>  	case MAX98373_R2054_MEAS_ADC_PVDD_CH_READBACK:
>  	case MAX98373_R2055_MEAS_ADC_THERM_CH_READBACK:
>  	case MAX98373_R20B6_BDE_CUR_STATE_READBACK: