linux-kernel - Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeB0Tago2foASYcGn_YUoh_HigDDag_X5WMTibRXxi72Q@mail.gmail.com>
Date:   Mon, 25 Jul 2022 22:29:34 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Srinivas Neeli <srinivas.neeli@...inx.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        neelisrinivas18@...il.com,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        srinivas.neeli@....com, Srinivas Goud <sgoud@...inx.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>
Subject: Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

On Mon, Jul 25, 2022 at 10:21 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> > > <srinivas.neeli@...inx.com> wrote:

...

> Reading again... You mean that
>
>   unsigned long x = y << 32;
>
> wouldn't work?

Yeah, I even checked this in asm, and indeed it doesn't work. Don't
know what was that about me...


Thanks for the fix,
Reviewed-by: Andy Shevchenko <andy.shevchenlko@...il.com>


-- 
With Best Regards,
Andy Shevchenko