linux-kernel - Re: [PATCH v4 5/5] iio: pressure: bmp280: Add more tunable config parameters for BMP380

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jul 2022 23:19:27 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Angel Iglesias <ang.iglesiasg@...il.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Paul Cercueil <paul@...pouillou.net>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 5/5] iio: pressure: bmp280: Add more tunable config
 parameters for BMP380

On Sat, Jul 23, 2022 at 7:40 PM Angel Iglesias <ang.iglesiasg@...il.com> wrote:
>
> Allows sampling frequency and IIR filter coefficients configuration
> using sysfs ABI.
>
> The IIR filter coefficient is configurable using the sysfs attribute
> "filter_low_pass_3db_frequency".
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@...il.com>

> Reported-by: Andy Shevchenko <andy.shevchenko@...il.com> # uninit var

Bugs in new features can't have Reported-by tag.

If you wish to give credit, use a cover letter / changelog.

...

> +               /*
> +                * Configuration errors are detected on the fly during a measurement

The configurations

> +                * cycle. If the sampling frequency is too low, it's faster to reset
> +                * measurement loop than wait until next measurement is due.

the measurement
the next

> +                * Resets sensor measurement loop toggling between sleep and normal
> +                * operating modes.
> +                */

-- 
With Best Regards,
Andy Shevchenko