linux-kernel - Re: [PATCH] Bluetooth: hci_sync: Fix opcode format in debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 11:58:02 -0700
From:   Luiz Augusto von Dentz <luiz.dentz@...il.com>
To:     Ismael Luceno <ismael@...ev.co.uk>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>
Subject: Re: [PATCH] Bluetooth: hci_sync: Fix opcode format in debug message

Hi Ismael,

On Sun, Jul 24, 2022 at 2:26 PM Ismael Luceno <ismael@...ev.co.uk> wrote:

Add some description, perhaps the debug output before and after the changes.

> Signed-off-by: Ismael Luceno <ismael@...ev.co.uk>
> ---
>  net/bluetooth/hci_sync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index 351c2390164d..d86d819465e8 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -150,7 +150,7 @@
>         struct sk_buff *skb;
>         int err = 0;
>
> -       bt_dev_dbg(hdev, "Opcode 0x%4x", opcode);
> +       bt_dev_dbg(hdev, "Opcode 0x%04x", opcode);
>
>         hci_req_init(&req, hdev);
>
> --
> 2.36.0
>


-- 
Luiz Augusto von Dentz