linux-kernel - Re: [PATCH] usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 12:41:08 -0700
From:   Wesley Cheng <quic_wcheng@...cinc.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <balbi@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <quic_jackp@...cinc.com>,
        <quic_mrana@...cinc.com>, <Thinh.Nguyen@...opsys.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Avoid duplicate requests to enable
 Run/Stop

Hi Greg,

On 7/26/2022 8:43 AM, Greg KH wrote:
> On Mon, Jul 25, 2022 at 01:11:36PM -0700, Wesley Cheng wrote:
>> Relocate the pullups_connected check until after it is ensured that there
>> are no runtime PM transitions.  If another context triggered the DWC3
>> core's runtime resume, it may have already enabled the Run/Stop.  Do not
>> re-run the entire pullup sequence again, as it may issue a core soft
>> reset while Run/Stop is already set.
>>
>> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
> 
> What commit does this fix?
> 
> How far back should it go to stable kernels?
> 
Let met add a fixes tag and resubmit.  Thanks!

Thanks
Wesley Cheng