linux-kernel - Re: Re: [PATCH] soc: amlogic: meson-pwrc: Hold reference returned by of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFBinCCzOt1s5ExH5H-BzmJbFLAzMZgkTvBt+vCuRBbL_1QQOg@mail.gmail.com>
Date:   Tue, 26 Jul 2022 07:18:33 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Liang He <windhl@....com>
Cc:     Neil Armstrong <narmstrong@...libre.com>, khilman@...libre.com,
        jbrunet@...libre.com, inux-amlogic@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] soc: amlogic: meson-pwrc: Hold reference returned by of_get_parent()

Hi Liang,

On Tue, Jul 26, 2022 at 3:18 AM Liang He <windhl@....com> wrote:
[...]
> I notice the declarations keep the reverse Christmas tree order,
> should I keep that order as the  'parent_np' will become longer than 'np'.
Good catch!
Personally I would move parent_np up (above pwrc) to keep the reverse
Christmas tree ordering, even for new variables.


Best regards,
Martin