linux-kernel - RE: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing accelerator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAPR01MB62010C6B98C1C197E7E894AF92949@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Date:   Tue, 26 Jul 2022 06:09:50 +0000
From:   <yuji2.ishikawa@...hiba.co.jp>
To:     <gregkh@...uxfoundation.org>
CC:     <robh+dt@...nel.org>, <hverkuil@...all.nl>,
        <nobuhiro1.iwamatsu@...hiba.co.jp>, <corbet@....net>,
        <sumit.semwal@...aro.org>, <christian.koenig@....com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linaro-mm-sig@...ts.linaro.org>
Subject: RE: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing
 accelerator driver

Hi Greg

Thank you for your comments.

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Monday, July 25, 2022 9:47 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>
> Cc: Rob Herring <robh+dt@...nel.org>; Hans Verkuil <hverkuil@...all.nl>;
> iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Jonathan Corbet <corbet@....net>;
> Sumit Semwal <sumit.semwal@...aro.org>; Christian König
> <christian.koenig@....com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; linux-media@...r.kernel.org;
> dri-devel@...ts.freedesktop.org; linaro-mm-sig@...ts.linaro.org
> Subject: Re: [PATCH v2 0/5] Add Toshiba Visconti DNN image processing
> accelerator driver
> 
> On Fri, Jul 22, 2022 at 05:28:53PM +0900, Yuji Ishikawa wrote:
> > This series is the DNN image processing accelerator driver for Toshiba's ARM
> SoC, Visconti[0].
> > This provides DT binding documentation, device driver, MAINTAINER files
> and documents.
> >
> > Best regards,
> > Yuji
> >
> > [0]:
> >
> https://toshiba.semicon-storage.com/ap-en/semiconductor/product/image-
> > recognition-processors-visconti.html
> >
> > dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing
> accelerator bindings
> >   v1 -> v2:
> >     - No update
> >
> > soc: visconti: Add Toshiba Visconti image processing accelerator common
> source
> >   v1 -> v2:
> >     - checked with checkpatch.pl --strict
> >
> > soc: visconti: Add Toshiba Visconti DNN image processing accelerator
> >   v1 -> v2:
> >     - checked with checkpatch.pl --strict
> >     - removed unused code
> >
> > MAINTAINERS: Add entries for Toshiba Visconti DNN image processing
> >   v1 -> v2:
> >     - No update
> >
> > Documentation: driver-api: visconti: add a description of DNN driver.
> >   v1 -> v2:
> >     - newly added documents
> >
> > Yuji Ishikawa (5):
> >   dt-bindings: soc: visconti: Add Toshiba Visconti DNN image processing
> >     accelerator bindings
> >   soc: visconti: Add Toshiba Visconti image processing accelerator
> >     common source
> >   soc: visconti: Add Toshiba Visconti DNN image processing accelerator
> >   MAINTAINERS: Add entries for Toshiba Visconti DNN image processing
> >     accelerator
> >   Documentation: driver-api: visconti: add a description of DNN driver.
> >
> >  .../soc/visconti/toshiba,visconti-dnn.yaml    |  54 ++
> >  Documentation/driver-api/visconti/common.rst  | 115 ++++
> >  Documentation/driver-api/visconti/dnn.rst     | 394 +++++++++++++
> >  MAINTAINERS                                   |   2 +
> >  drivers/soc/Kconfig                           |   1 +
> >  drivers/soc/Makefile                          |   1 +
> >  drivers/soc/visconti/Kconfig                  |   7 +
> >  drivers/soc/visconti/Makefile                 |   8 +
> >  drivers/soc/visconti/dnn/Makefile             |   6 +
> >  drivers/soc/visconti/dnn/dnn.c                | 523
> ++++++++++++++++++
> >  drivers/soc/visconti/dnn/hwd_dnn.c            | 183 ++++++
> >  drivers/soc/visconti/dnn/hwd_dnn.h            |  68 +++
> >  drivers/soc/visconti/dnn/hwd_dnn_reg.h        | 228 ++++++++
> >  drivers/soc/visconti/ipa_common.c             |  55 ++
> >  drivers/soc/visconti/ipa_common.h             |  18 +
> >  drivers/soc/visconti/uapi/dnn.h               |  77 +++
> >  drivers/soc/visconti/uapi/ipa.h               |  90 +++
> 
> Why is this in drivers/soc/?

Actually, I'm not sure where his module should live in.
The directory drivers/soc were chosen just because the driver is specific to Visconti SoC.
Is it better to move the driver to another directory such as drivers/misc ?

> And uapi files belong in the correct include path, not burried in a driver
> subdirectory where they will never be picked up correctly by the build system.
> How did you test these?

I understand it's not a good idea to place uapi files under driver subdirectory.
A build command "make headers_install" did not pick out headers.
I used additional shell script to install headers for Visconti.
I'll move uapi headers to include/uapi/linux.

> thanks,
> 
> greg k-h

Regards,
  Yuji