linux-kernel - RE: [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAPR01MB6201F55F3E0B036E875963E692949@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Date:   Tue, 26 Jul 2022 06:10:43 +0000
From:   <yuji2.ishikawa@...hiba.co.jp>
To:     <corbet@....net>, <robh+dt@...nel.org>, <hverkuil@...all.nl>,
        <nobuhiro1.iwamatsu@...hiba.co.jp>, <sumit.semwal@...aro.org>,
        <christian.koenig@....com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linaro-mm-sig@...ts.linaro.org>
Subject: RE: [PATCH v2 5/5] Documentation: driver-api: visconti: add a
 description of DNN driver.

Hi Jonathan

Thank you for your comments

> -----Original Message-----
> From: Jonathan Corbet <corbet@....net>
> Sent: Friday, July 22, 2022 10:33 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; Rob Herring <robh+dt@...nel.org>; Hans
> Verkuil <hverkuil@...all.nl>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@...hiba.co.jp>; Sumit Semwal
> <sumit.semwal@...aro.org>; Christian König <christian.koenig@....com>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linux-media@...r.kernel.org; dri-devel@...ts.freedesktop.org;
> linaro-mm-sig@...ts.linaro.org; ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○
> ＥＡ開) <yuji2.ishikawa@...hiba.co.jp>
> Subject: Re: [PATCH v2 5/5] Documentation: driver-api: visconti: add a
> description of DNN driver.
> 
> Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp> writes:
> 
> No changelog?
> 

I'll add more detailed changelog.

> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@...hiba.co.jp>
> > ---
> > v1 -> v2:
> >   - newly added documents
> > ---
> >  Documentation/driver-api/visconti/common.rst | 115 ++++++
> >  Documentation/driver-api/visconti/dnn.rst    | 394
> +++++++++++++++++++
> >  2 files changed, 509 insertions(+)
> >  create mode 100644 Documentation/driver-api/visconti/common.rst
> >  create mode 100644 Documentation/driver-api/visconti/dnn.rst
> 
> Two overall comments:
> 
>  - You've added new RST files without adding them to index.rst; that
>    will keep them from being part of the kernel docs build and will add
>    new warnings.

I'll add index.rst to put these documents into the toc tree.

>  - Please avoid the use of flat-table and just use regular RST
>    ascii-art tables.  Otherwise the result is nearly unreadable in the
>    plain-test format.

All right, flat-table will be replaced with regular table.

> Thanks,
> 
> jon

Regards,
  Yuji