linux-kernel - Re: [PATCH] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 08:30:06 +0200
From:   David Jander <david@...tonic.nl>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: dts: imx6qdl-vicut1.dtsi: Add backlight-isb node

On Mon, 25 Jul 2022 22:33:12 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 25/07/2022 14:48, David Jander wrote:
> > On some older hardware models this is needed. It will do no harm if used
> > with newer models though.
> > 
> > Signed-off-by: David Jander <david@...tonic.nl>
> > ---
> >  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> > index a1676b5d2980..08d425020088 100644
> > --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> > @@ -37,6 +37,16 @@ backlight_led: backlight_led {
> >  		power-supply = <&reg_3v3>;
> >  	};
> >  
> > +	/* only for backwards compatibility with old HW */
> > +	backlight_isb: backlight_isb {  
> 
> Node name: backlight-isb
> 
> I know that other node had underscore, but these are not correct for names.

I know the names are not correct, but they are in the style of existing node
names in the same file. Do you want me to change them all, or just this one?
This change would break existing user-space software though, which is something
I prefer not to do. Unfortunately both names are relied upon by user-space
software for almost 10 years now, and changing them will force me to maintain
off-tree patches that revert these changes.
I understand the reason for the change though, and if you insist I will do it.

Best regards,

-- 
David Jander